Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for local mappings and conditional questions #1

Closed
6 tasks done
zanerock opened this issue Mar 16, 2023 · 1 comment · Fixed by #2
Closed
6 tasks done

Add tests for local mappings and conditional questions #1

zanerock opened this issue Mar 16, 2023 · 1 comment · Fixed by #2
Assignees
@zanerock
Labels
assigned This task has been assigned/claimed. enhancement New feature or request
Milestone
1.0.0-beta

Comments

@zanerock
Copy link
Member

zanerock commented Mar 16, 2023 •
edited
Loading

Overview

Need more testing.

Deliverables

  • Add test for local (question-attached) mappings.
  • Add test for positive conditional question.
  • Add test for negative conditional question.
  • Test each of the parameter types.

Found while testing:

  • Use 'http-error's createError consistently.
  • Add standard scripts to package.json
@zanerock zanerock added the bug Something is broken label Mar 16, 2023
@zanerock zanerock added this to the 1.0.0-beta milestone Mar 16, 2023
@zanerock zanerock added the assigned This task has been assigned/claimed. label Mar 16, 2023
@zanerock
Copy link
Member Author

Work for this issue will begin begin on branch work-liquid-labs/question-and-answer/1.

@zanerock zanerock self-assigned this Mar 16, 2023
@zanerock zanerock added enhancement New feature or request and removed bug Something is broken labels Mar 16, 2023
@zanerock zanerock mentioned this issue Mar 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zanerock zanerock

Labels
assigned This task has been assigned/claimed. enhancement New feature or request
Projects
None yet
Milestone
1.0.0-beta
Development

Successfully merging a pull request may close this issue.

Add tests for local mappings and conditional questions liquid-labs/question-and-answer
1 participant
@zanerock