Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gettin the eval parameters (internal) is modifying initial parameters #40

Closed
1 task done
zanerock opened this issue Mar 24, 2023 · 1 comment · Fixed by #41
Closed
1 task done

Gettin the eval parameters (internal) is modifying initial parameters #40

zanerock opened this issue Mar 24, 2023 · 1 comment · Fixed by #41
Assignees
@zanerock
Labels
assigned This task has been assigned/claimed. bug Something is broken
Milestone
1.0.0-beta

Comments

@zanerock
Copy link
Member

Overview

The Object.assign in #evalParams should put everything on a new object to make a copy, but it's putting it directly onto the initial parameters.

Deliverables

  • Create a new object in #evalParams
@zanerock zanerock added the bug Something is broken label Mar 24, 2023
@zanerock zanerock added this to the 1.0.0-beta milestone Mar 24, 2023
@zanerock zanerock added the assigned This task has been assigned/claimed. label Mar 24, 2023
@zanerock
Copy link
Member Author

Work for this issue will begin begin on branch work-liquid-labs/question-and-answer/40.

@zanerock zanerock self-assigned this Mar 24, 2023
@zanerock zanerock mentioned this issue Mar 24, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zanerock zanerock

Labels
assigned This task has been assigned/claimed. bug Something is broken
Projects
None yet
Milestone
1.0.0-beta
1 participant
@zanerock