-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing the DDPG agent #206
Fixing the DDPG agent #206
Conversation
Hey @raimannma thanks for updating the branch! Not sure if you got a chance to look at the TravisCI build but it seems like there's some long-lived process in the unit tests that is logging and the build was unable to finish. Would you be able to look into why that's happening? |
Oh, this seems to be just a timeout problem. My PC is so much faster than the travis-ci server. |
if I test it locally, everything works just fine. Can you retry the travis build? |
Hey @raimannma, just tried to re-run the Travis build but wasn't able to, I think Travis has a time limit to re-run builds. Any chance you could make a tiny chance and push to the branch? If possible removing the console logging could make the test run much faster |
Hey, I am not sure where the bug is, probably it's the noise function. |
Yeah, I've found that debugging ML code is often really tough. Even with unit tests isolating where things happen is usually a tall order. That's part of the reason I've been trying to work on a way to log events for NNs in a Redux-style so you can see whenever changes happen to the network structure / configuration and step forwards / backwards in time. For now what about trying to just log everything and follow the execution of the code? Maybe that could help to find the bug |
There is an issue with the target networks. I will do this whoule reinforcement things in the new typescript version. |
Here comes a fix for the DDPG agent