Tracking issue for release 1.4.0 #151
Comments
I receive this error on arch linux, not running as root. I have the Corsair Hydro Series H115i Pro RGB. Not sure if there is support for it. |
|
Can you post the output of |
|
Sure thing |
|
Does Endeavour use vanilla Arch Linux packages (for core and community, not AUR), or does it have its own repositories? Also, what Finally, can you please show me the output of the following command? It should (indirectly) tell me which backend is being used by Can you please take a look a this, since you're more familiar than me with this driver? At first glance it seems like an invalid response (report ID should not be 0 if the device supports reports) from an older firmware version, but maybe you've seen this problem before. On another front, can you please test the latest code in the main branch (as whole, not just this specific driver) and make sure everything still works for you? |
|
Hey @jonasmalacofilho, afaik endeavour uses vanilla, but how can I check? I did install this using As for the version checking, not quite sure how to do that. Output of the command: |
I found a page in Endeavour's docs that appears to say that it's indeed vanilla/from Arch's repositories. But I honestly don't know how to check this either. I guess you could take a look at your
Yay has the same option, if you use it for all your package management.
Thanks! |
|
Just a heads-up...I'll boot into Kubuntu Linux shortly (on the Gigabyte Z490 Vision D) and check the latest code. This system has the 0x5702 controller, but I can still test Linux compatibility of the latest code. On macOS, however, the latest code (main branch, Fusion 2 driver) works correctly. It was downloaded and tested a couple of hours ago. I'll test the NZXT Smart Device V2 later in the day since that's on a different machine (ASRock X570 Taichi) that is in temporary storage.
|
|
** Update ** I am not seeing any problems running the latest master branch on Kubuntu Linux 20.04 on my Gigabyte Z490 Vision D. This board has the ITE Tech 0x5702. @sgtsixpack successfully tested an earlier Windows version on Gigabyte X570 with the 0x8297 controller. casey@Z490-VISION-D:~/.local/lib/python3.8/site-packages/liquidctl/driver$ liquidctl --verbose initialize
Gigabyte RGB Fusion 2.0 5702 Controller (experimental)
├── Hardware name IT5702-GIGABYTE V1.0.10.0
├── Firmware version 1.0.10.0
└── LED channnels 7
casey@Z490-VISION-D:~/.local/lib/python3.8/site-packages/liquidctl/driver$ liquidctl --verbose list
Device ID 0: Gigabyte RGB Fusion 2.0 5702 Controller (experimental)
├── Vendor ID: 0x048d
├── Product ID: 0x5702
├── Release number: 0x0001
├── Bus: hid
├── Address: /dev/hidraw3
└── Driver: RGBFusion2Driver using module hidraw
casey@Z490-VISION-D:~/.local/lib/python3.8/site-packages/liquidctl/driver$ liquidctl -g initialize
[DEBUG] liquidctl.cli: running liquidctl v1.3.3
[DEBUG] liquidctl.driver.usb: searching HidapiBus (api=hidraw, drivers=[CommonSmartDeviceDriver, CoolitPlatinumDriver, CorsairHidPsuDriver, KrakenTwoDriver, KrakenX3Driver, KrakenZ3Driver, RGBFusion2Driver, SeasonicEDriver, SmartDeviceDriver, SmartDeviceV2Driver])
[DEBUG] liquidctl.driver.usb: probing drivers for device 048d:5702
[DEBUG] liquidctl.driver.usb: instanced driver for Gigabyte RGB Fusion 2.0 5702 Controller (experimental)
[DEBUG] liquidctl.driver.usb: probing drivers for device 046d:4051
[DEBUG] liquidctl.driver.usb: probing drivers for device 046d:405b
[DEBUG] liquidctl.driver.usb: probing drivers for device 046d:c52b
[DEBUG] liquidctl.driver.usb: searching PyUsbBus (drivers=[AsetekDriver, CommonAsetekDriver, CorsairAsetekDriver, LegacyAsetekDriver])
[DEBUG] liquidctl.driver.usb: probing drivers for device 1d6b:0003
[DEBUG] liquidctl.driver.usb: probing drivers for device 1d6b:0002
[DEBUG] liquidctl.driver.usb: probing drivers for device 0bda:0411
[DEBUG] liquidctl.driver.usb: probing drivers for device 1d6b:0003
[DEBUG] liquidctl.driver.usb: probing drivers for device 046d:c52b
[DEBUG] liquidctl.driver.usb: probing drivers for device 046d:082d
[DEBUG] liquidctl.driver.usb: probing drivers for device 0bda:5411
[DEBUG] liquidctl.driver.usb: probing drivers for device 8087:0026
[DEBUG] liquidctl.driver.usb: probing drivers for device 048d:5702
[DEBUG] liquidctl.driver.usb: probing drivers for device 05ac:828d
[DEBUG] liquidctl.driver.usb: probing drivers for device 0a5c:4500
[DEBUG] liquidctl.driver.usb: probing drivers for device 05e3:0608
[DEBUG] liquidctl.driver.usb: probing drivers for device 1d6b:0002
[DEBUG] liquidctl.cli: device: Gigabyte RGB Fusion 2.0 5702 Controller (experimental)
[DEBUG] liquidctl.driver.usb: sending feature report 0xcc with 63 bytes: 60:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00
[DEBUG] liquidctl.driver.usb: got feature report 0xcc with 63 bytes: 01:00:07:01:00:0a:00:00:00:00:00:49:54:35:37:30:32:2d:47:49:47:41:42:59:54:45:20:56:31:2e:30:2e:31:30:2e:30:00:00:00:00:01:02:00:02:00:01:00:02:00:01:00:00:01:02:00:00:01:02:57:00:00:00:00
Gigabyte RGB Fusion 2.0 5702 Controller (experimental)
├── Hardware name IT5702-GIGABYTE V1.0.10.0
├── Firmware version 1.0.10.0
└── LED channnels 7 |
|
Is this a new version? Want me to test? Have u changed anything which could affect things on my end? |
|
@sgtsixpack, I'm not sure what version you are running. Just in case, can you update to the build for @CaseySJ, you had a earlier firmware version before? Do you remember whether it was before or after 1.0.6.0? |
|
Some error here (working ok): |
|
My Vision D has always had 1.0.10.0. As you can see from #127 (comment), the original USB captures had 1.0.10.0. Perhaps @sgtsixpack reported 1.0.6.0 on the 0x8297?
|
|
@sgtsixpack can you also post the output of |
|
|
Sorry, my bad: |
|
|
I'll check my installation of Windows with the 0x5702. |
|
No errors on Windows 10 with 0x5702 device: |
|
The previous version liquidctl-7c6afd0b01a2-bin-windows-x86_64 had no errors for me. This one is the one I just tested: |
The 0x8297 device does not seem to be placing REPORT_ID The 0x5702 device returns REPORT_ID |
|
U think a restart could fix it? Maybe you could write a bit of code to save what it replies with? Would that help? |
If a device doesn't support report IDs, it may reply to any get_feature_report. The returned report will have report ID 0x00. Related: #151 (comment)
That's unexpected, as I can't sse any functional changes to that the assertion or the lower level code that could explain this difference. Regardless, please test 8cc5c788307d. Please test I would also like to see the HID descriptor, can you please post the output of |
|
So I tested the one I thought was working and got the same output: |
|
Latest version (8cc5c78): |
|
Does this number of channels (1) makes sense? |
|
Manual says:
but 8 & 9 are duplicated on different corners of the board. https://www.gigabyte.com/Motherboard/X570-AORUS-ELITE-rev-10/support#support-manual So my board has at three channels for plugable strips (5 plugables in total). It has lighting on the motherboard itself. I believe on the IO port and near the onboard audio. So that is five channels. I need to check though, and I do not have RGB fusion installed. |
|
@haringsrob Thank you! Decoding this (using a convenient online tool) we get... This is all pretty much in line with our driver, and (according to the spec) the 8297 devices should respond with the report ID too. I'll add some notes in the code indicating that this has been checked and that it is indeed a bug in the device, not our code. |
|
Let's also add |
After taking a look at 8297's HID descriptor we now classify the
device's behavior as out of spec. Update the code and the comments to
clarify that and to prevent future bugs.
0x06, 0x89, 0xFF, // Usage Page (Vendor Defined 0xFF89)
0x09, 0x10, // Usage (0x10)
0xA1, 0x01, // Collection (Application)
0x85, 0x5A, // Report ID (90)
0x09, 0x01, // Usage (0x01)
0x15, 0x00, // Logical Minimum (0)
0x26, 0xFF, 0x00, // Logical Maximum (255)
0x75, 0x08, // Report Size (8)
0x95, 0x10, // Report Count (16)
0xB1, 0x00, // Feature (Data,Array,Abs,No Wrap,Linear,Preferred State,No Null Position,Non-volatile)
0xC0, // End Collection
0x06, 0x89, 0xFF, // Usage Page (Vendor Defined 0xFF89)
0x09, 0xCC, // Usage (0xCC)
0xA1, 0x01, // Collection (Application)
0x85, 0xCC, // Report ID (-52)
0x09, 0x01, // Usage (0x01)
0x15, 0x00, // Logical Minimum (0)
0x26, 0xFF, 0x00, // Logical Maximum (255)
0x75, 0x08, // Report Size (8)
0x95, 0x3F, // Report Count (63)
0xB1, 0x00, // Feature (Data,Array,Abs,No Wrap,Linear,Preferred State,No Null Position,Non-volatile)
0xC0, // End Collection
Raw version:
# usbhid-dump -d 048d:8297
003:002:000:DESCRIPTOR 1595619527.478157
06 89 FF 09 10 A1 01 85 5A 09 01 15 00 26 FF 00
75 08 95 10 B1 00 C0 06 89 FF 09 CC A1 01 85 CC
09 01 15 00 26 FF 00 75 08 95 3F B1 00 C0
Related: #151 (comment)
We already presumed an eight channel could be available, from the traffic captured to implement reset_all_channels. Enable it in case it's useful for anyone. Suggested-by: @CaseySJ Related: #151 (comment)
Even with the potential fixed from commit c2200fa ("hydro_platinum: Remove component abstraction in set_color"), this feature is not sufficiently tested to be enabled by default on the impending 1.4.0 release. Require `--unsafe pro_xt_lighting` (or equivalent when directly calling the API) to enable. Related: #149 ("H100i RGB PRO XT Lighting not responding to commands") Related: #151 ("Tracking issue for release 1.4.0")
|
Hi, |
|
@mburgholte, can you show me your complete lsusb output and HID descriptor for your RGB Fusion? You can get the latter by installing usbutils and running sudo usbhid-dump -d 048d:8297, and the former with |
|
Hi @jonasmalacofilho, |
|
Due to this new issue with the 8297 controllers, can I also ask you for the output of |
|
In the meantime, you can also use the filter options (of which It's an inclusive filter, and I honestly don't plan to add an exclusive one. But, luckily, all of your other devices will match When you said that "Everything else works like a charm", did you mean the other devices or other commands on the same RGB Fusion controller? |
This comment has been minimized.
This comment has been minimized.
|
This was off-topic; in the future, please try reach me through email, twitter or discord for general help. That said, I think your problem is that you meant to use |
|
Hey @jonasmalacofilho here it is: |
Hi @jonasmalacofilho, |
|
Got it, thanks! Can you test if you're again able to |
Hi @jonasmalacofilho, |
|
@mburgholte, great! And once again, thanks! |
|
Done, liquidctl v1.4.0 is out! : ) |
|
We added |
|
I'm quite busy testing my raid 10 install, |
|
Understood; no rush. If P.S. I used to cook once a week before the pandemic, but working from home changes many routines. Cooking is enjoyable, especially if you grow many of your own vegetables! |
|
@sgtsixpack thanks for letting me know about the typos. (Something confused the markdown syntax highlighter, and that made the spell checker completely ignore all normal text...) But have you been cooking more, or less? I usually find it very enjoyable, lately not so much... |
|
Oh btw I made a flat gradient (except for between 37 & 38'c water temp) of 4.61% fan speed between 25 & 38 degrees water temperature as my 3 x 3k Noctua industrial fans were idling @TooLoud%: |
|
Been cooking a lot more and trying new recipes. It's wonderful when you can walk out into the garden (100% organic of course) and pick ripe vegetables for consumption the same day. Just-in-time delivery never tasted so good.
|
|
Cool (pun intended). But, in the future, liquidctl can do the math for you. Should be equivalent to your manual profile, ± rounding errors. You can check this by adding That's sounds super nice. Unfortunately I live in an apartment, so I'm limited to very small plants. But I should look into it! Do you have any suggestions besides the usual herbs and spices? |
When the pandemic began it gave me the opportunity to put more time and effort into the backyard, which is something I had neglected for too long. I started by building six raised planter boxes, each measuring 0.61m (2ft) x 1.52m (5ft) and then watching a number of YouTube gardening channels, among them:
Good lessons on organic soil, starting from seed, soil amendment, plant nutrition at different phrases, organic pest control methods (cold pressed neem oil with soap), etc. I've added some photos to my Flickr album. This began in April and now in August it's astonishing how much the plants have grown and how much food they're producing. This being my first ever attempt at gardening, I decided to grow:
I should have done this sooner! |
During the next two weeks I'll be finalizing a new liquidctl release, version 1.4.0. If you can, please start to test the code in the main branch; you can use this issue to report any problems.
The most notable user-facing changes in this version will be the addition of drivers for fourth-generation Kraken X coolers (with limited support for Kraken Z coolers as well), Corsair Platinum coolers (with limited support for PRO XT coolers as well), and some Gigabyte motherboards with RGB Fusion 2.0 controllers.
I'll be updating the changelog during the next few days with all other significant changes, and there are some improvements I still hope to finish in time for the release.
Linux package maintainers may also want to follow any updates I make to the
liquidctl-gitAUR PKGBUILD for ArchLinux.Thank you Tom, Casey, Sean, and all other contributors. Thank you for contributing drivers or fixes, capturing or helping analyze USB traffic, reporting bugs, or simply getting in touch.
If you're working on a new feature or bug fix, please feel free to open pull requests normally during this two-week window. I'll evaluate on a case-by-case basis whether a particular change can safely get into this release...
And from now on I intend to do periodic releases every three months. The changes accepted into the main branch at the time will determinate whether it's a patch or minor release.
The text was updated successfully, but these errors were encountered: