Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use updated winusbcdc #535

Merged
merged 2 commits into from
Nov 24, 2022
Merged

Conversation

ShadyNawara
Copy link
Contributor

Describe what the changes are meant to address.

My changes to upstream winsubcdc were accepted and a new version was released (1.5). this pr cleans up the unneeded code under "_find_winusb_device" in the kraken3 driver

If the implementation is not trivial, please also include a short overview.

Fixes:
Closes:
Related: #479


Checklist:

New CLI flag?

  • Adjust the completion scripts in extra/completions/

New device?

  • Regenerate extra/linux/71-liquidctl.rules (instructions in the file header)
  • Add entry to the README's supported device list with applicable notes (at least e) and git MRLV

New driver?

  • Document the protocol in docs/developer/protocol/

Copy link
Member

@jonasmalacofilho jonasmalacofilho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great news, and thanks for keeping track of it.

The changes to kraken3.py LGTM, but setup.cfg, the GH workflows and the README also need to be updated to explicitly require at least the new 1.5 version of winusbcdc.

@ShadyNawara
Copy link
Contributor Author

That's great news, and thanks for keeping track of it.

The changes to kraken3.py LGTM, but setup.cfg, the GH workflows and the README also need to be updated to explicitly require at least the new 1.5 version of winusbcdc.

done

@jonasmalacofilho
Copy link
Member

Thanks!

@jonasmalacofilho jonasmalacofilho merged commit 7bda2f3 into liquidctl:main Nov 24, 2022
@jonasmalacofilho jonasmalacofilho added this to the liquidctl 1.12.0 milestone Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants