Use CanInterface() to avoid panic on unexported fields

This needs tests before merging.
liquidgecka · Nov 19, 2016 · 259ff64 · 259ff64
1 parent aa5f957
commit 259ff64
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/equal.go b/equal.go
@@ -206,13 +206,21 @@ func (t *T) deepEqual(
 	checkNil := func() bool {
 		if want.IsNil() && !have.IsNil() {
 			diffs = append(diffs, fmt.Sprintf("%s: not equal.", desc))
-			diffs = append(diffs, fmt.Sprintf("  have: %#v", have.Interface()))
+			if have.CanInterface() {
+				diffs = append(diffs, fmt.Sprintf("  have: %#v", have.Interface()))
+			} else {
+				diffs = append(diffs, "  have <unexported field>")
+			}
 			diffs = append(diffs, "  want: nil")
 			return true
 		} else if !want.IsNil() && have.IsNil() {
 			diffs = append(diffs, fmt.Sprintf("%s: not equal.", desc))
 			diffs = append(diffs, "  have: nil")
-			diffs = append(diffs, fmt.Sprintf("  want: %#v", want.Interface()))
+			if want.CanInterface() {
+				diffs = append(diffs, fmt.Sprintf("  want: %#v", want.Interface()))
+			} else {
+				diffs = append(diffs, "  want <unexported field>")
+			}
 			return true
 		}
 		return false