Ensure that equality on unicode chars works. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liquidgecka
force-pushed
the
equal_should_be_equal
branch
from
995671a
to
2eb52e2
Compare
philpennock
approved these changes
Nov 18, 2016
| for i := range hstr { | ||
| if hstr[i] != wstr[i] { | ||
| for i, r := range hrunes { | ||
| if r != wrunes[i] { | ||
| return []string{ | ||
| fmt.Sprintf("%s: difference at index %d.", desc, i), |
There was a problem hiding this comment.
nit: I think this indexing is now a little confusing; how is it indexed? s/index/rune/?
Error message does not clearly guide the user to the correct point.
Unicode characters were broken as it would only compare the first byte of the character due to the strange way that string indexing works in golang. This converts that to a working rune iteration which is far safer and catches errors. A regression test was added in order to test for this case in the future.
liquidgecka
force-pushed
the
equal_should_be_equal
branch
from
2eb52e2
to
8b251b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unicode characters were broken as it would only compare the last byte of
the character due to the strange way that string indexing works in
golang. This converts that to a working rune iteration which is far
safer and catches errors.
A regression test was added in order to test for this case in the
future.