Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(security): Run CodeQL scan on PRs and on schedule #212

Merged
merged 1 commit into from
Nov 5, 2021
Merged

chore(security): Run CodeQL scan on PRs and on schedule #212

merged 1 commit into from
Nov 5, 2021

Conversation

yitsushi
Copy link
Contributor

@yitsushi yitsushi commented Nov 4, 2021 •
edited
Loading

What this PR does / why we need it:

Code scan is good.

Which issue(s) this PR fixes:

Fixes #84

Special notes for your reviewer:

The skipped check:

The very first time code scanning is run and if it is on a pull request, you will probably get a message mentioning a "missing analysis". This is expected.
Source: https://github.com/github/codeql-action#note-on-missing-analysis-message

Checklist:

  • squashed commits into logical changes

@yitsushi yitsushi added kind/feature New feature or request area/security Indicates issue or PR relates to security labels Nov 4, 2021
richardcase
richardcase approved these changes Nov 4, 2021
View reviewed changes
Copy link
Member

@richardcase richardcase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've never used the autobuild myself but seems to work. This all looks good to me.

@yitsushi yitsushi merged commit 4b30e20 into liquidmetal-dev:main Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardcase richardcase richardcase approved these changes

Assignees
No one assigned
Labels
area/security Indicates issue or PR relates to security kind/feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add code scanning with CodeQL
2 participants
@yitsushi @richardcase