Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service file for systemd #324

Merged
merged 3 commits into from
Dec 20, 2021

Conversation

Callisto13
Copy link
Member

@Callisto13 Callisto13 commented Dec 14, 2021

As part of my docs writing I realised that having an option to manage flintlockd with systemd looks a bit more pro than "start the server with an &".

The --parent-iface flag is of course required and means some sort of user input. I did consider an EnvironmentFile, but it's a bit "eh" and the systemd creators deeply regret its inclusion.
I am documenting that users need to do something here.

@Callisto13 Callisto13 added the kind/feature New feature or request label Dec 14, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2021

Codecov Report

Merging #324 (06e753f) into main (5f8d70c) will not change coverage.
The diff coverage is n/a.

❗ Current head 06e753f differs from pull request most recent head c937ad8. Consider uploading reports for the commit c937ad8 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #324   +/-   ##
=======================================
  Coverage   58.03%   58.03%           
=======================================
  Files          51       51           
  Lines        2509     2509           
=======================================
  Hits         1456     1456           
- Misses        936      937    +1     
+ Partials      117      116    -1     
Impacted Files Coverage Δ
infrastructure/containerd/event_service.go 56.14% <0.00%> (-3.51%) ⬇️
pkg/queue/queue.go 100.00% <0.00%> (+6.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aef9e33...c937ad8. Read the comment docs.

@yitsushi
Copy link
Contributor

We have viper included, i wonder why we don't have a --config option.

@Callisto13
Copy link
Member Author

are we not removing viper?

@Callisto13
Copy link
Member Author

but yeh if urfave/cli has a config file then we can use that

@richardcase
Copy link
Member

but yeh if urfave/cli has a config file then we can use that

The PR that Soule has done for urfave/cli does have a config file option.

@Callisto13
Copy link
Member Author

👍 do we want that as part of this PR or can i move forward with this one and come back to that?

@richardcase
Copy link
Member

+1 do we want that as part of this PR or can i move forward with this one and come back to that?

Lets come back to it

@Callisto13 Callisto13 merged commit 6b96272 into liquidmetal-dev:main Dec 20, 2021
@Callisto13 Callisto13 deleted the add-service-file branch December 20, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants