modify provision.sh to accept grpc port #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardcase
previously requested changes
May 16, 2023
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #708 +/- ##
==========================================
- Coverage 58.26% 58.18% -0.08%
==========================================
Files 56 56
Lines 2705 2705
==========================================
- Hits 1576 1574 -2
- Misses 983 985 +2
Partials 146 146
☔ View full report in Codecov by Sentry. |
|
One last thing I would like to see if you don't mind @aryan9600 is an output of the config if you run this with and without the parameter is still consistent and looks okay. In the etc flintlock config file. |
|
|
Fantastic, thank you. |
Skarlso
approved these changes
May 25, 2023
Modify provision.sh to accept a custom GRPC port using -p or --grpc-port. Fix a couple of return statements using the wrong error Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
yitsushi
approved these changes
May 25, 2023
| @@ -169,7 +169,7 @@ func (im *imageService) snapshotAndMount(ctx context.Context, | |||
| logger.Debugf("image %s isn't unpacked, unpacking using %s snapshotter", image.Name(), snapshotter) | |||
|
|
|||
| if unpackErr := image.Unpack(ctx, snapshotter); unpackErr != nil { | |||
| return nil, fmt.Errorf("unpacking %s with snapshotter %s: %w", image.Name(), snapshotter, err) | |||
| return nil, fmt.Errorf("unpacking %s with snapshotter %s: %w", image.Name(), snapshotter, unpackErr) | |||
| @@ -413,7 +418,7 @@ lookup_interface() { | |||
| lookup_address() { | |||
| local interface="$1" | |||
|
|
|||
| ip route show | awk -v i="$interface" '$0 ~ i {print $9}' | grep -E '^(192\.168|10\.|172\.1[6789]\.|172\.2[0-9]\.|172\.3[01]\.)' | |||
| ip route show | awk -v i="$interface" '$0 ~ i {print $9}' | grep -E '^(192\.168|10\.|172\.1[6789]\.|172\.2[0-9]\.|172\.3[01]\.)' -m 1 | |||
There was a problem hiding this comment.
I don't even know why we didn't have the -m 1 option there before.
| @@ -92,7 +92,7 @@ func (p *fcProvider) startFirecracker(cmd *exec.Cmd, vmState State, detached boo | |||
| } | |||
|
|
|||
| if startErr != nil { | |||
| return nil, fmt.Errorf("starting firecracker process: %w", err) | |||
| return nil, fmt.Errorf("starting firecracker process: %w", startErr) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kind/bug
What this PR does / why we need it:
Modify provision.sh to accept a custom GRPC port using -p or --grpc-port. Currently we hardcode 9090 and provide no way to override it.
Fix a couple of return statements using the wrong error
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #568
Special notes for your reviewer:
Checklist: