Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS X: missing battery charge level #444

Closed
wants to merge 1 commit into from
Closed

OS X: missing battery charge level #444

wants to merge 1 commit into from

Conversation

augmentedfourth
Copy link
Contributor

_lp_battery refactor in 4636e0e caused battery percentages to no longer
be displayed in OS X. Adding the echo statements it removed back in.

_lp_battery refactor in 4636e0e caused battery percentages to no longer
be displayed in OS X. Adding the echo statements it removed back in.
@augmentedfourth
Copy link
Contributor Author

I wish I'd been able to get this into 1.10, but I only just noticed the problem when pushing the release to Homebrew today...

dolmen added a commit that referenced this pull request Jun 1, 2016
Fix bug introduced in 4636e0e: battery level was not reported anymore on
MacOS X.
@dolmen
Copy link
Collaborator

dolmen commented Jun 1, 2016

It looks like 1.11 will be a small release with fixes only...

@dolmen dolmen changed the title Revert Darwin portion of 4636e0e (_lp_battery refactor) OS X: missing battery charge level Jun 1, 2016
@dolmen dolmen added bug MacOS X Related to MacOS X specific implementation battery Related to battery data or display labels Jun 1, 2016
@dolmen
Copy link
Collaborator

dolmen commented Jun 1, 2016

Thanks for the report. I choose to implement the fix in a different way.

@dolmen dolmen closed this Jun 1, 2016
@dolmen dolmen self-assigned this Jun 1, 2016
dolmen added a commit that referenced this pull request Jun 1, 2016
@dolmen dolmen added the fixed! label Jun 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
battery Related to battery data or display bug MacOS X Related to MacOS X specific implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants