Change command variable assignments to use LC_ALL #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LC_ALL and specific locale variables like LC_NUMERIC override LANG, so if a user sets a locale variable like LC_NUMERIC in their shell, using LANG as a command variable assignment won't change anything. This causes the command to output in the users local and could cause parsing errors. In places where we need the output to be in ANSI C format, set LC_ALL=C instead of LANG. On line 1066, both LANG and LC_ALL don't need to be set, since LC_ALL takes precedence. The change to include both was done in commit 0fb81d5. Fixes #548
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #548.
The docs for this mechanic can be found here: https://www.gnu.org/software/gettext/manual/html_node/Locale-Environment-Variables.html
LC_ALL and specific locale variables like LC_NUMERIC override LANG, so
if a user sets a locale variable like LC_NUMERIC in their shell, using
LANG as a command variable assignment won't change anything. This causes
the command to output in the users locale and could cause parsing errors.
In places where we need the output to be in ANSI C format, set LC_ALL=C
instead of LANG.
On line 1066, both LANG and LC_ALL don't need to be set, since LC_ALL
takes precedence. The change to include both was done in commit
0fb81d5.