Feat+error meaning #745
Merged
Feat+error meaning #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rycieos
requested changes
Oct 23, 2022
|
Do I squash all commits into one ? (i.e. do you want to keep the extended error meaning setup?) |
Rycieos
requested changes
Oct 24, 2022
There was a problem hiding this comment.
Looks good now.
I missed that question the first time, sorry. I do not have much of an opinion. Clearly you intended for both bits to be part of the feature, so it would be fine in once commit. But if you want it as separate, I'm fine with that.
But no matter what, squash away the extra commits from the fixes and docs.
|
The two commits were only there to make it easy to just have a single config, if you're OK with the "extended" config, I'll squash everything. |
nojhan
force-pushed
the
feat+error-meaning
branch
from
a66a6d1
to
44bf1a4
Compare
Rycieos
requested changes
Oct 25, 2022
- Displays the (guessed) meaning of the last error code (feature request #729). - Use a set of reasonably common error codes on POSIX systems (but is LP used out of a POSIX env?). - Use the color than lp_error (namely LP_COLOR_ERR). - Put in the default theme right after the error code. - Code would be very much simpler/configurable with Bash 4's associative arrays, but here use a case switch with non-configurable error meanings. - Use a separated LP_ENABLE_ERROR_MEANING. - Adds LP_ENABLE_ERROR_MEANING_EXTENDED to allow for a larger set of error codes (let the user decide the level of guess for error meaning). - doc: update prompt comparison with error meaning
nojhan
force-pushed
the
feat+error-meaning
branch
from
44bf1a4
to
c0b2b0f
Compare
Rycieos
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically displays the (guessed) meaning of the last error code (feature request #729).
Separated in two commits, so that you may allow a more or less granular level of details.
First commit: adds the core feature.
(but is LP used out of a POSIX env?).
but here use a case switch with non-configurable error meanings.
Second commit: let the user decide the level of guess for error meaning.