New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(presets): adds config-from-doc and several presets #772
Conversation
Add two presets: - more-unicode - nerd-font Add four color schemes: - 256 colors for dark themes. - 256 colors for light themes. - red-green blindnesses. - blue-yellow blindness. Doc: - mention presets in themes and config. - fix doc about OS and CMake. Misc: - Also uses exit code 2 on tools scripts, which is the convention for usage errors. - update debian pkg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking pretty good mostly.
This broke the Homebrew formula, which copies liquidprompt-dist from the root of the repo into @Rycieos Would you prefer the Homebrew installation to generate the -dist file and provide it as an example (as it always has), or give users a link to the documentation here on GitHub? I can do the documentation link pretty easily, but it would take a while for me to find time to make Homebrew generate and deploy the default config file. |
Proposed Homebrew documentation change if I go with the latter (simpler) version:
|
Maybe the appropriate documentation link should be this one? |
I would rather see links to documentation, as it will be the most helpful. You could also add a bit about the generation script and how to use it since some might find that useful. Yes, that is the correct link for the |
OK. I've set up a commit where the regular install will output:
And
I will include a message about generating a default config file once there's a release that includes the tool. Adding that message to just |
Argh. It looks like the current generation of Homebrew maintainers are trying to stop hosting other projects' documentation and only use their "caveats" section for details that are specific to the Homebrew distribution. "most people do not read the caveats and even less people will if we start using it for all kinds of documentation." They're asking me to remove that I'd prefer to do nothing and just wait for the tool to exist everywhere, but the lack of the sample config file is breaking Homebrew HEAD installation with the current formula. |
Yeah that's not ideal. Just remove the install of the configfile stub for now? |
That's my plan. I just hope we don't have any problems reintroducing it later. |
Features:
config-from-doc.sh
script, to automatically generate a default "liquidpromptrc" config file from the documentation (fix Up-to-date presets examples #755).LP_COLOR_OS_*
.LP_MARK_OS_SEP
to the same separator than the CMake's one by default (more consistent).LP_ENABLE_CMAKE_COLORS
for enabling auto color based on hash.LP_COLOR_CMAKE_*
variables when one do not want hash colors.LP_COLOR_SCLS
Fix along the way:
theme-preview.sh
, to allow preview of presets using public functions (i.e.lp_terminal_format
).Technical checklist:
IFS
_LP_FIRST_INDEX
_LP_PERCENT
_LP_SHELL_*
)tests/test_*.sh
files)test.sh
shellcheck.sh
(requires shellcheck)... versionadded:: X.Y
or.. versionchanged:: Y.Z
docs/docs-lint.sh
(requires Python 3 andrequirements.txt
installed (
cd docs/; python3 -m venv venv; . venv/bin/activate; pip install -r requirements.txt
))