Avoid running __lp_set_prompt multiple times #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rycieos
requested changes
Mar 4, 2024
steelman
force-pushed
the
prompt-command-cleanup
branch
from
4d78f30
to
03faf14
Compare
Unlike lp_activate lp_theme hasn't cleand PROMPT_COMMAND. Thus, __lp_set_prompt was dded each time a theme was switched. In case of a single theme switch (e.g. from the default to dotmatrix) the performance hit due to running __lp_set_prompt twice wasn't noticable. However, the second time the function was called, it didn't show the last command runtime properly even if it was longer than LP_RUNTIME_THRESHOLD. Fixes: 3553a65 ("Add support for Bash 5.1+ PROMPT_COMMAND array")
steelman
force-pushed
the
prompt-command-cleanup
branch
from
03faf14
to
5f54c4b
Compare
Rycieos
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike lp_activate lp_theme hasn't cleand PROMPT_COMMAND. Thus, __lp_set_prompt was dded each time a theme was switched. In case of a single theme switch (e.g. from the default to dotmatrix) the performance hit due to running __lp_set_prompt twice wasn't noticable. However, the second time the function was called, it didn't show the last command runtime properly even if it was longer than LP_RUNTIME_THRESHOLD.
Fixes: 3553a65 ("Add support for Bash 5.1+ PROMPT_COMMAND array")
Technical checklist:
tests/test_*.shfiles)tests.shshellcheck.sh(requires shellcheck).