This repository has been archived by the owner on Jun 15, 2022. It is now read-only.
Add support for --batch-size=0 to CLI commands #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally, update both the CLI documentation and README to reflect that `--batch-size=0` disables batching.
stevegrunwell
added
enhancement
cli migration
Closed
bswatson
approved these changes
Jan 28, 2020
|
@bswatson It looks like the WooCommerce team is actively preparing 3.9.2, so some core tests are currently failing on WooCommerce 3.9 releases for this PR but those are unrelated to our work. I don't know that it should block this moving forward into |
|
@stevegrunwell As long as they aren't specific to changes we've made, then I would say we're ok to move it forward. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For both
migrateandbackfill, passing--batch-size=0should disable batching. For smaller sites, batching may be unnecessary and seems to be the cause of some issues with migration.This PR builds upon and replaces #140.