This repository has been archived by the owner on Jun 15, 2022. It is now read-only.
Handle exceptions during migration #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d logged) and instead extract information from them when running the CLI migration command
…s on servers with lower memory limits
…c method By default, any public, non-static methods on a WP-CLI command class will be picked up by WP-CLI as an available subcommand, which is less-than-desireable. Unfortunately, the WP plugin API requires that callbacks be public, so a static method helps prevent it from being treated as a valid subcommand.
stevegrunwell
added
bug
cli migration
|
@bswatson As a heads up, the tests against trunk are currently failing the same test as #60, which is awaiting merge in woocommerce/woocommerce#20045. |
bswatson
approved these changes
May 17, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR leverages the "woocommerce_caught_exception" action to ensure that any exceptions that are raised during the execution of WooCommerce functions (such as
wc_get_order()) are escalated and logged accordingly by WP-CLI.Additionally, this PR lowers the default batch size for
migrate/backfillfrom 1000 to 100, which results in more frequent database queries but a lower memory footprint, which will be important for less-powerful servers (such as in #49).Fixes #56.