Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to fetch for Polylith git deps #117

Closed
seancorfield opened this issue Nov 2, 2021 · 7 comments
Closed

Failed to fetch for Polylith git deps #117

seancorfield opened this issue Nov 2, 2021 · 7 comments

Comments

@seancorfield
Copy link
Contributor

Repro:

(! 1168)-> cat deps.edn 
{:deps {io.github.polyfy/polylith {:git/tag "v0.2.13-alpha" :git/sha "88c1f4c" :deps/root "projects/poly"}}}

(! 1169)-> clojure -Sdeps '{:deps {antq/antq {:mvn/version "1.1.0"}}}' -M -m antq.core

|    :file |                     :name |      :current |         :latest |
|----------+---------------------------+---------------+-----------------|
| deps.edn | io.github.polyfy/polylith | v0.2.13-alpha | Failed to fetch |
@seancorfield
Copy link
Contributor Author

With 1.0.2, it seems to correctly fetch the dependency and show that an updated SHA is available (but it shows 88c1f4c instead of the tag, and the available SHA to be b32f375 which is correct but not a tagged version), so I think this is a bug in the new :git/tag logic?

@liquidz
Copy link
Owner

liquidz commented Nov 3, 2021

@seancorfield Thanks for your report! I'll have a look.

@liquidz
Copy link
Owner

liquidz commented Nov 3, 2021

It seems all tags ends with alpha..., and those versions are filtered in the following.

liquidz added a commit that referenced this issue Nov 3, 2021
@liquidz
Copy link
Owner

liquidz commented Nov 3, 2021

@seancorfield
I haven't tested it enough yet, but I've done a quick fix in the bugfix/qualified-versions branch.

@seancorfield
Copy link
Contributor Author

Thank you for the quick fix @liquidz -- I have tested that on our monorepo full of deps.edn files and it seems to work as expected!

@liquidz
Copy link
Owner

liquidz commented Nov 5, 2021

@seancorfield Thanks for your confirmation!
I just released v1.2.0 #119

@seancorfield
Copy link
Contributor Author

I updated the script at work to use 1.2.0 it looks good. Thank you!

@liquidz liquidz closed this as completed Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants