Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SHA for annotated tags #137

Closed
liquidz opened this issue Jan 20, 2022 · 1 comment
Closed

Use SHA for annotated tags #137

liquidz opened this issue Jan 20, 2022 · 1 comment

Comments

@liquidz
Copy link
Owner

liquidz commented Jan 20, 2022

Currently, antq uses SHA for deps on git, where the tag is an exact match.
But, for example, tools.build contains annotated tags, so there are two SHAs for a particular version.

$ git ls-remote --tags
...
2526f58294a24c1ff94e4ce33c24c19552f921f2        refs/tags/v0.7.5
34727f790d0b4d568fe3b5699ce6ebfcc1f55d39        refs/tags/v0.7.5^{}

So the current upgrading process will update SHA to 2526f58 instead of 34727f7.
This works, but it is preferable to handle annotated tags in antq too, because 34727f7 is handled on GitHub and in tools.gitlibs.

liquidz added a commit that referenced this issue Jan 20, 2022
@liquidz
Copy link
Owner Author

liquidz commented Jan 22, 2022

Closed by #142

@liquidz liquidz closed this as completed Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant