Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slf4j-simple dependency caused to crash #16

Closed
maxp opened this issue Jul 24, 2020 · 8 comments
Closed

slf4j-simple dependency caused to crash #16

maxp opened this issue Jul 24, 2020 · 8 comments

Comments

@maxp
Copy link

maxp commented Jul 24, 2020

I have a line in deps.edn org.slf4j/slf4j-simple {:mvn/version "1.7.30"} and got an exception.

"Execution error (ClassCastException) at unilog.config/start-logging! (config.clj:354).\nclass org.slf4j.impl.SimpleLogger cannot be cast to class ch.qos.logback.classic.Logger (org.slf4j.impl.SimpleLogger and ch.qos.logback.classic.Logger are in unnamed module of loader 'app')\n",

{:clojure.error/class java.lang.ClassCastException,
:clojure.error/line 354,
:clojure.error/cause
"class org.slf4j.impl.SimpleLogger cannot be cast to class ch.qos.logback.classic.Logger (org.slf4j.impl.SimpleLogger and ch.qos.logback.classic.Logger are in unnamed module of loader 'app')",
:clojure.error/symbol unilog.config/start-logging!,
:clojure.error/source "config.clj",
:clojure.error/phase :execution}

@maxp
Copy link
Author

maxp commented Jul 24, 2020

@maxp
Copy link
Author

maxp commented Jul 28, 2020

Looks like unilog.config strictly depends on logback's Logger.
https://github.com/pyr/unilog/blob/master/src/unilog/config.clj#L339

@liquidz
Copy link
Owner

liquidz commented Jul 28, 2020

@maxp Sorry for late reply!
I'll have a look!

@liquidz
Copy link
Owner

liquidz commented Jul 28, 2020

@maxp I could reproduce the problem.
unilog is not mandatory, so I'll delete it from dependencies.

liquidz added a commit that referenced this issue Jul 28, 2020
@liquidz
Copy link
Owner

liquidz commented Jul 28, 2020

@maxp I've cut a new release.
https://clojars.org/antq/versions/0.5.3
Could you try ver 0.5.3?

@maxp
Copy link
Author

maxp commented Jul 28, 2020

Works great!

@liquidz
Copy link
Owner

liquidz commented Jul 28, 2020

Thanks for your confirmation!

@liquidz
Copy link
Owner

liquidz commented Jul 28, 2020

Closed by #17

@liquidz liquidz closed this as completed Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants