Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade is not working when dependency version is destructed. #241

Closed
Kaspazza opened this issue Nov 27, 2023 · 7 comments
Closed

Upgrade is not working when dependency version is destructed. #241

Kaspazza opened this issue Nov 27, 2023 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@Kaspazza
Copy link

Running upgrade on deps.edn will always tell which versions to update, but will not follow through if the version is saved as:
#:mvn{:version "x.x"}
And will work correctly if the dependency is written in fully qualified keyword like:
{:mvn/version "x.x"}

@liquidz
Copy link
Owner

liquidz commented Dec 1, 2023

@Kaspazza Thanks for your reporting!
Ah, I missed it. I'll fix!

@liquidz liquidz added the bug Something isn't working label Dec 1, 2023
@liquidz liquidz self-assigned this Dec 1, 2023
@liquidz
Copy link
Owner

liquidz commented Dec 2, 2023

@Kaspazza I've fixed in bugfix/upgrade-with-destructed branch.
Could you try?

@Kaspazza
Copy link
Author

Kaspazza commented Dec 5, 2023

@liquidz Hi, thank you for the quick reply and fix!

Yeah, it works, but it asks twice about the same dependencies (both with destructured or not)

I run it with code, requiring [antq.core]
(antq.core/-main --upgrade --directory=/absolute/path/to/my/repo --exclude lib --exclude lib2 --exclude lib3)

First it asks about ~/absolute/path/to/my/repo/deps.edn
and second time about relative deps.edn

Here is a screenshot:
image

@liquidz
Copy link
Owner

liquidz commented Dec 10, 2023

Hmm, I'll have a look.

liquidz added a commit that referenced this issue Dec 28, 2023
liquidz added a commit that referenced this issue Dec 28, 2023
@liquidz
Copy link
Owner

liquidz commented Dec 28, 2023

@Kaspazza Sorry, I've been unwell.

Yeah, it works, but it asks twice about the same dependencies (both with destructured or not)

Thanks for your reporting! This was another bug and I've fixed in the same branch.
Could you try bugfix/upgrade-with-destructed branch again?

liquidz added a commit that referenced this issue Jan 2, 2024
@liquidz
Copy link
Owner

liquidz commented Jan 2, 2024

@Kaspazza Just released v2.8.1165 :)

@liquidz liquidz closed this as completed Jan 2, 2024
@Kaspazza
Copy link
Author

Kaspazza commented Jan 2, 2024

@liquidz Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants