Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate entries on github actions update #246

Closed
dharrigan opened this issue Jan 9, 2024 · 5 comments
Closed

Duplicate entries on github actions update #246

dharrigan opened this issue Jan 9, 2024 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@dharrigan
Copy link
Sponsor Contributor

dharrigan commented Jan 9, 2024

Hi!

Clojure CLI version 1.11.1.1435
com.github.liquidz/antq {:mvn/version "2.8.1169"}

When running against a repo that has .github/workflows/*.yml, duplicate entries are created if (I think) there is an additional line between steps.

Before (notice the additional line between the build and publish steps):

---

name: Production

on:
  push:
  workflow_dispatch:

jobs:
  build:
    name: Build
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v3


  publish:
    name: Publish
    runs-on: ubuntu-latest
    steps:
      - uses: actions/cache@v3
        id: restore-build
        with:
          path: ./*
          key: ${{ github.sha }}-${{ github.run_number }}-${{ github.run_attempt }}

Executing: clojure -X:antq

after:

---

name: Production

on:
  push:
  workflow_dispatch:

jobs:
  build:
    name: Build
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v4


  publish:
    name: Publish
    runs-on: ubuntu-latest
    steps:
      - uses: actions/cache@v3
        id: restore-build
        with:
          path: ./*
          key: ${{ github.sha }}-${{ github.run_number }}-${{ github.run_attempt }}

  publish:
    name: Publish
    runs-on: ubuntu-latest
    steps:
      - uses: actions/cache@v3
        id: restore-build
        with:
          path: ./*
          key: ${{ github.sha }}-${{ github.run_number }}-${{ github.run_attempt }}

I've created a repo where you can reproduce this issue: https://github.com/dharrigan/antq-issue-246

-=david=-

@liquidz
Copy link
Owner

liquidz commented Jan 10, 2024

@dharrigan Thanks for your reporting!
I could reproduce the problem. I'll fix it :)

@liquidz liquidz added the bug Something isn't working label Jan 10, 2024
@liquidz liquidz self-assigned this Jan 10, 2024
@liquidz
Copy link
Owner

liquidz commented Jan 10, 2024

Memo: this is a problem on the rewrite-indented side.

liquidz added a commit that referenced this issue Jan 10, 2024
@liquidz
Copy link
Owner

liquidz commented Jan 10, 2024

@dharrigan I've fixed this problem in dev branch.
Could you try dev branch?

@dharrigan
Copy link
Sponsor Contributor Author

Hi,

Works perfectly. ありがとう :-)

-=david=-

@liquidz
Copy link
Owner

liquidz commented Jan 10, 2024

@dharrigan Thanks for your confirmation!
I just released v2.8.1173 :)

@liquidz liquidz closed this as completed Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants