Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

antq.api/upgrade-deps! not working for dependencies that are keyword extracted #251

Closed
Kaspazza opened this issue Mar 28, 2024 · 5 comments
Assignees

Comments

@Kaspazza
Copy link

Kaspazza commented Mar 28, 2024

Running this:
(antq.api/upgrade-deps! [{:type :clojure, :file "automaton/automaton_core/bb.edn", :dependency {:name "org.clojars.hephaistox/automaton-build", :latest-version "1.3.0-5-la"}}])

Won't work if bb.edn (or deps.edn the same behavior on all) looks like this:
{:deps #:org.clojars.hephaistox{automaton-build #:mvn{:version "1.0.2"}}}
Which is perfectly valid format.

But will work if it looks like this:
{:deps {org.clojars.hephaistox/automaton-build #:mvn{:version "1.0.2"}}

So having the namespace extended outside of curly brackets make it don't succeed (even though function itself returns true).

@liquidz
Copy link
Owner

liquidz commented Apr 3, 2024

@Kaspazza Sorry for late reply and thank you for your reporting!
I'll have a look.

@liquidz liquidz self-assigned this Apr 3, 2024
@liquidz
Copy link
Owner

liquidz commented Apr 6, 2024

@Kaspazza I've fixed the problem in dev branch.
Could you try dev branch?

@Kaspazza
Copy link
Author

Kaspazza commented Apr 8, 2024

@liquidz It works great! Thanks!

@liquidz
Copy link
Owner

liquidz commented Apr 9, 2024

@Kaspazza Thanks for your confirmation!
I'll release new version in this weekend.

@liquidz
Copy link
Owner

liquidz commented Apr 12, 2024

@Kaspazza Just released v2.8.1194 :)

@liquidz liquidz closed this as completed Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants