Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when running in the REPLy project #39

Closed
bbatsov opened this issue Nov 19, 2020 · 10 comments
Closed

Error when running in the REPLy project #39

bbatsov opened this issue Nov 19, 2020 · 10 comments

Comments

@bbatsov
Copy link

bbatsov commented Nov 19, 2020

I got a weird error when running antq on https://github.com/trptcolin/reply

$ lein outdated
OpenJDK 64-Bit Server VM warning: Options -Xverify:none and -noverify were deprecated in JDK 13 and will likely be removed in a future release.
Exception in thread "main" java.lang.RuntimeException: Unable to resolve symbol: qualified-symbol? in this context, compiling:(antq/dep/boot.clj:38:40)

That's with the latest version of antq. It seems to run fine on other projects I've tried it with.

@liquidz
Copy link
Owner

liquidz commented Nov 19, 2020

@bbatsov clojure 1.7.0 may be the cause

@bbatsov
Copy link
Author

bbatsov commented Nov 19, 2020

If I had to guess it's probably because REPLy targets Clojure 1.7 and antq is probably targetting some newer version, but that was unclear from the CI/docs.

@bbatsov
Copy link
Author

bbatsov commented Nov 19, 2020

Hah, it seems we wrote this at the same time. :-)

@bbatsov
Copy link
Author

bbatsov commented Nov 19, 2020

After testing it seems that antq requires current Clojure 1.9. Not sure if that's a hard dep or something that can be adjusted.

@liquidz
Copy link
Owner

liquidz commented Nov 19, 2020

Thanks :)
I'll have a look.

@liquidz
Copy link
Owner

liquidz commented Nov 19, 2020

Supporting Clojure 1.8.0 is easy.

Prior to 1.7.0, as shown in the State of Clojure 2020 results, not many people use it, so I'll update to show a warning message.
https://clojure.org/news/2020/02/20/state-of-clojure-2020

liquidz added a commit that referenced this issue Nov 19, 2020
@liquidz
Copy link
Owner

liquidz commented Nov 19, 2020

I tried to support Clojure 1.8 and add warning on Clojure 1.7 or earlier in dev branch.

I'll update documents tomorrow.

@bbatsov
Copy link
Author

bbatsov commented Nov 19, 2020

Thanks!

@liquidz
Copy link
Owner

liquidz commented Nov 27, 2020

Added suuport for Clojure 1.8 and warning on Clojure 1.7 or earlier by #40

@liquidz liquidz closed this as completed Nov 27, 2020
@bbatsov
Copy link
Author

bbatsov commented Nov 28, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants