Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect dependencies which has unverified group name #63

Closed
liquidz opened this issue Mar 9, 2021 · 5 comments
Closed

Detect dependencies which has unverified group name #63

liquidz opened this issue Mar 9, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@liquidz
Copy link
Owner

liquidz commented Mar 9, 2021

It will be a disallow list simply for now.
e.g. seancorfield/next.jdbc => com.github.seancorfield/next.jdbc
c.f. Clojars Verified Group Names policy

@liquidz
Copy link
Owner Author

liquidz commented Mar 13, 2021

@nnichols
Hi,

I have a plan to release this feature.
In this feature, I will change the output a little with format reporter.

For example, if you have seancorfield/next.jdbc {:mvn/version "1.1.613"} in you deps.edn, antq will report like follows.

# Option: --reporter=format --error-format="{{name}},{{version}},{{latest-version}},{{latest-name}}"
# For unverified deps, `latest-version` will be "Failed to fetch" and `latest-name` is set
seancorfield/next.jdbc,seancorfield/next.jdbc,Failed to fetch,com.github.seancorfield/next.jdbc
seancorfield/next.jdbc,1.1.613,1.1.643,

In clojure-dependency-update-action, reports containing "Failed to fetch" will be ignored, so I don't think it will affect your GitHub Action.
https://github.com/nnichols/clojure-dependency-update-action/blob/v3/dependency-check.sh#L24

But if you don't mind, could you confirm to make sure your GitHub Action works well?

You can try this feature on dev branch.

nnichols added a commit to nnichols/clojure-dependency-update-action that referenced this issue Mar 13, 2021
@nnichols
Copy link
Contributor

@liquidz I updated the Action with this commit nnichols/clojure-dependency-update-action@0fc9b2d and was able to successfully run a few test cases in a sample repo.

Thanks for this update!!

@liquidz
Copy link
Owner Author

liquidz commented Mar 13, 2021

@nnichols Thanks for your confirmation!

@liquidz liquidz added the enhancement New feature or request label Mar 13, 2021
@liquidz
Copy link
Owner Author

liquidz commented Mar 13, 2021

@nnichols FYI: I just released v0.12.0 :)

@liquidz
Copy link
Owner Author

liquidz commented Mar 13, 2021

Closed by #65

@liquidz liquidz closed this as completed Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants