Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider supporting blacklisting a specific dependency version #75

Closed
lread opened this issue May 7, 2021 · 6 comments
Closed

Consider supporting blacklisting a specific dependency version #75

lread opened this issue May 7, 2021 · 6 comments

Comments

@lread
Copy link

lread commented May 7, 2021

Still loving antq, thanks @liquidz!

Scenario: I am using antq to check for outdated dependencies. I reports that there is a new version v of dependency d. I discover though that there is a serious enough bug in dependency d version v that'd I do not want to upgrade.

Ideally I'd like to tell antq to no longer tell me about dependency d version v being available. I'm just not interested.
I am, though, interested in learning about the next version v of dependency d when it becomes available.

Not sure what form this exclusion config would take, thought I'd first check if the idea might be of interest.

@liquidz
Copy link
Owner

liquidz commented May 8, 2021

@lread Thanks for your suggestion!

Not sure what form this exclusion config would take, thought I'd first check if the idea might be of interest.

Indeed.
Sometimes I'd like to ignore specific version.
The feature will help me too :)

We have already --exclude option to ignore specific dependency, so for example, we can extend this option to be able to specify version like --excude=d@v.
(I believe the dep@version format is common because it is used by npm, brew, etc)

@lread
Copy link
Author

lread commented May 8, 2021

Yeah, I think that'd work well @liquidz. I currently only see need to blacklist one version, I think(?).

Here's a nuance: Let's say I am at version 1.1.0 of lib x and the current release version is 1.1.2. I know I don't want 1.1.2, so I exclude x@1.1.2. If there is a v1.1.1 also available, would antq recommend v1.1.1? Or I am I really excluding v1.1.2 and all version before it?

@liquidz
Copy link
Owner

liquidz commented May 8, 2021

@lread

Here's a nuance: Let's say I am at version 1.1.0 of lib x and the current release version is 1.1.2. I know I don't want 1.1.2, so I exclude x@1.1.2. If there is a v1.1.1 also available, would antq recommend v1.1.1? Or I am I really excluding v1.1.2 and all version before it?

It seems intuitive that x@1.1.2 excludes only v1.1.2.
So v1.1.1 should be reported as available. (because v1.1.0 is outdated)

antq has a version list internally, and it shouldn't be too hard.

@lread
Copy link
Author

lread commented May 8, 2021

Sounds good! So if we were wanting to exclude multiple versions of lib x, I would simply specify both --exclude=x@1.1.1 and --exclude@1.1.2

@liquidz
Copy link
Owner

liquidz commented May 9, 2021

@lread I've not tested enough yet, but I've tried to add the feature in dev branch.

liquidz added a commit that referenced this issue May 10, 2021
@liquidz
Copy link
Owner

liquidz commented May 11, 2021

Just released v0.14.0 #76
Feel free to reopen it you have any problems :)

@liquidz liquidz closed this as completed May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants