Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to changelogs when available #84

Closed
vemv opened this issue Jun 3, 2021 · 7 comments
Closed

Link to changelogs when available #84

vemv opened this issue Jun 3, 2021 · 7 comments

Comments

@vemv
Copy link
Contributor

vemv commented Jun 3, 2021

Hi again,

I liked this feature:

Available diffs:
- https://github.com/clojure/clojure/compare/clojure-1.10.1...1.10.3

Additionally, one could try printing https://github.com/clojure/clojure/blob/clojure-1.10.3/changes.md if that file exists (as of that tag). A few filenames could be atttempted to be fetched:

  • changes.md
  • CHANGELOG.md
  • CHANGELOG.adoc

and so on. I checked that one can query those files via HEAD so as not to spam much github's servers.

WDYT? I could give it a shot.

@liquidz
Copy link
Owner

liquidz commented Jun 3, 2021

@vemv Thanks for your suggestion!

Oh, it is the feature I've been wanteded for a long time! (I didn't have time to start yet)

I checked that one can query those files via HEAD so as not to spam much github's servers.

Great!

@vemv
Copy link
Contributor Author

vemv commented Jun 3, 2021

Nice! I'll try to contribute it sometime this week

@vemv
Copy link
Contributor Author

vemv commented Jun 9, 2021

FYI I'm progressing well with this feature :) hope to open a PR in a few days

@liquidz
Copy link
Owner

liquidz commented Nov 9, 2021

NOTE: clj-http has changelog.org
https://github.com/dakrone/clj-http/blob/3.x/changelog.org

liquidz added a commit that referenced this issue Nov 19, 2021
liquidz added a commit that referenced this issue Nov 19, 2021
@vemv
Copy link
Contributor Author

vemv commented Dec 8, 2021

Hey there!

I hadn't forgotten about this one, but was hesitant about which http library to use.

I successfully pushed for https://github.com/clj-commons/clj-http-lite to move to clj-commons and to solve some outstanding tech issues.

It seems a very nice library since it's dependency-free, and it works with all JDKs.

Feel free to consider using it.

Regarding my branch and the more recent commits from your side, I wouldn't mind much discarding my work. When your branch is ready feel free to @ me, I might contribute some ideas from what I had committed 👀

liquidz added a commit that referenced this issue Sep 16, 2022
@liquidz
Copy link
Owner

liquidz commented Sep 18, 2022

@vemv Just released v2.1.920 :)

@vemv
Copy link
Contributor Author

vemv commented Sep 19, 2022

Nice! Will check it out :)

@vemv vemv closed this as completed Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants