Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect :default-deps for Clojure CLI #155

Merged
merged 2 commits into from Apr 7, 2022
Merged

Detect :default-deps for Clojure CLI #155

merged 2 commits into from Apr 7, 2022

Conversation

grzm
Copy link
Contributor

@grzm grzm commented Apr 6, 2022

:default-deps is a resolve-deps modifier.

See https://clojure.org/reference/deps_and_cli#_resolve_deps_modifiers

It is sometimes used to indicate "managed-dependencies" or common pinned versions. See the following discussions

:default-deps isn't used by the cli tool directly, but is a known argument in the tooling itself.

We use this internally to indicate managed dependencies and having antq detect :default-deps would be useful.

:default-deps is a resolving-deps modifier.
@liquidz
Copy link
Owner

liquidz commented Apr 6, 2022

@grzm Thanks for your contribution!

Could you change the following line too?

(contains? #{:deps :extra-deps :replace-deps :override-deps})))

And it may be good that we have the set as constant value.
https://github.com/liquidz/antq/blob/main/src/antq/constant.clj

@grzm
Copy link
Contributor Author

grzm commented Apr 6, 2022

Thanks for the suggestions! That makes a lot of sense in the context of the project as a whole.

Copy link
Owner

@liquidz liquidz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grzm LGTM! Thanks!

@liquidz liquidz merged commit e2c680d into liquidz:main Apr 7, 2022
liquidz added a commit that referenced this pull request Apr 7, 2022
@grzm
Copy link
Contributor Author

grzm commented Apr 7, 2022

Thanks for your review and merge, @liquidz !

@grzm grzm deleted the grzm/detect-default-deps branch April 7, 2022 23:49
@liquidz
Copy link
Owner

liquidz commented Apr 8, 2022

@grzm Just released v1.6.1 #156

@grzm
Copy link
Contributor Author

grzm commented Apr 9, 2022

🎉 🚀 🎸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants