Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for :match-exactly in :documents #29

Merged
merged 1 commit into from
Jul 22, 2023
Merged

Conversation

ivarref
Copy link
Contributor

@ivarref ivarref commented Jul 22, 2023

Hi @liquidz

and thanks for many great open source projects!

I've added support for :match-verbatim in :documents.
Is that of interested for the project? I think it's good not to have to escape e.g. the dot (.) when doing replace.

I don't know malli and I guess that the new ?document schema could be improved. Feel free to tweak it as you like.

Appreciate your feedback.
Kind regards

@liquidz
Copy link
Owner

liquidz commented Jul 22, 2023

@ivarref Thanks for your contributing!

Is that of interested for the project? I think it's good not to have to escape e.g. the dot (.) when doing replace.

It looks good to me :)

I've added support for :match-verbatim in :documents.

I'm not sure how commonly the word "verbatim" is used, but I thought "exactly" might be easier to understand in terms of its usage. What do you think?

@ivarref
Copy link
Contributor Author

ivarref commented Jul 22, 2023

I agree exactly is easier to understand @liquidz . I've updated the commit (squashed) and also added documentation in documents.adoc.

@ivarref ivarref changed the title Add support for :match-verbatim in :documents Add support for :match-exactly in :documents Jul 22, 2023
@liquidz liquidz merged commit 362c7c9 into liquidz:main Jul 22, 2023
1 check passed
@liquidz
Copy link
Owner

liquidz commented Jul 22, 2023

Thank you!

@liquidz
Copy link
Owner

liquidz commented Jul 22, 2023

@ivarref Just released 0.10.227 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants