Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: All strategies get invoked instead of just first one found #2

Closed
lirantal opened this issue Jul 7, 2019 · 1 comment
Closed
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@lirantal
Copy link
Owner

lirantal commented Jul 7, 2019

Expected Behavior

Even if I have multiple strategies supported, such as having both the detect-secrets tool as well as docker installed, and both can be used I expect that only one is used (the first one detected) and then stop without continuing to running the next one, which results in 2 reports for the same file being scanned.

Current Behavior

All available strategies getting invoked.

Possible Solution

Detect when strategies get invoked and don't continue to the next strategies if so.

Steps to Reproduce (for bugs)

  1. Have Yelp's detect-secrets available in the path
  2. Have Docker available in the path
  3. Run detect-secrets-launcher for a file and both will be invoked
@lirantal lirantal added bug Something isn't working good first issue Good for newcomers labels Jul 7, 2019
@lirantal lirantal self-assigned this Jul 19, 2019
@lirantal
Copy link
Owner Author

Fixed in 932ba73

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant