Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(browser-version): added a warning about the version requirement #51

Merged
merged 1 commit into from
Dec 5, 2019

Conversation

travi
Copy link
Contributor

@travi travi commented Dec 5, 2019

Related Issue

based on conversation from form8ion/javascript-scaffolder#24 (comment)

happy to tie to an issue that is local to this project if you'd prefer

Motivation and Context

i ran into an issue when i pushed to travis. a quick search for the error suggested that the installed chrome was too old which was easily remedied by specifying a newer version, but i could see that tripping up some users.

How Has This Been Tested?

builds after adding the browser version have been working as expected, for example: https://travis-ci.org/travi-org/matt.travi.org/builds/619116313#L655-L662

Checklist:

  • I have updated the documentation (if required).
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I added a picture of a cute animal cause it's fun

@lirantal lirantal self-requested a review December 5, 2019 14:38
@lirantal lirantal added the documentation Improvements or additions to documentation label Dec 5, 2019
@lirantal
Copy link
Owner

lirantal commented Dec 5, 2019

Looks great, thanks @travi

@lirantal lirantal merged commit 22f743b into lirantal:master Dec 5, 2019
@github-actions
Copy link

github-actions bot commented Dec 5, 2019

🎉 This PR is included in version 1.9.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@travi travi deleted the browser-version branch December 5, 2019 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants