Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide more verbose output on issues found #9

Closed
lirantal opened this issue Aug 30, 2019 · 2 comments
Closed

Provide more verbose output on issues found #9

lirantal opened this issue Aug 30, 2019 · 2 comments
Assignees
@emimuresan
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@lirantal
Copy link
Owner

Is your feature request related to a problem? Please describe.
Currently when an issue is found during a linting script run the information provided on the error is pretty limited, such as:

ABORTING lockfile lint process due to error exceptions
Invalid URL: false
TypeError [ERR_INVALID_URL]: Invalid URL: false
    at onParseError (internal/url.js:240:17)
    at parse (internal/url.js:249:3)

Would be better to provide more verbose information on errors such as the actual package this was detected on and so on.
@lirantal lirantal added enhancement New feature or request good first issue Good for newcomers labels Aug 30, 2019
emimuresan added a commit to emimuresan/lockfile-lint that referenced this issue Oct 12, 2019
@emimuresan
feat: 🎸 Add custom error which outputs the package name too
0904df3 
Closes: lirantal#9
emimuresan added a commit to emimuresan/lockfile-lint that referenced this issue Oct 12, 2019
@emimuresan
refactor: 💡 Add new line after each error log in abort case
ffd5291 
Closes: lirantal#9
@emimuresan emimuresan mentioned this issue Oct 12, 2019
Merged
8 tasks
@emimuresan
Copy link
Contributor

Hi @lirantal ! I created a PR for this. Please take a look when you get a chance. Thank you!

@lirantal
Copy link
Owner Author

Addressed in #13

@lirantal lirantal mentioned this issue Oct 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emimuresan emimuresan

Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lirantal @emimuresan