Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(repository): defined repository.path property in package.json #142

Merged
merged 1 commit into from
Sep 27, 2022
Merged

fix(repository): defined repository.path property in package.json #142

merged 1 commit into from
Sep 27, 2022

Conversation

travi
Copy link
Contributor

@travi travi commented Sep 27, 2022

Description

defining repository.path in each package.json should inform tools like renovate to properly find the CHANGELOG.md files

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Related Issue

fixes #141

Motivation and Context

without this information, tools like renovate look in the root of the repo and fail to find the details for the individual packages

How Has This Been Tested?

Screenshots (if appropriate):

Checklist:

  • I have updated the documentation (if required).
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I added a picture of a cute animal cause it's fun

@travi
fix(repository): defined repository.path property in package.json
3d4cf59 
which should enable services like renovate to find release notes
lirantal
lirantal approved these changes Sep 27, 2022
View reviewed changes
Copy link
Owner

@lirantal lirantal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you Matt!

@lirantal lirantal added the bug Something isn't working label Sep 27, 2022
@lirantal lirantal merged commit c4180ef into lirantal:master Sep 27, 2022
@travi travi deleted the repository-path branch September 28, 2022 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lirantal lirantal lirantal approved these changes

Assignees

@travi travi

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Renovate PRs don't include release notes
2 participants
@travi @lirantal