Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error variable was shadowed by function #162

Merged
merged 1 commit into from
May 24, 2023

Conversation

lirantal
Copy link
Owner

@lirantal lirantal commented May 24, 2023

Description

Prior to this fix, an error stack trace would be printed due to a bug in lockfile-lint's error handling.
It happened due to the error() function shadowing the local error variable in a try/catch scope.

Types of changes

This PR fixes that undefined error.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Checklist:

  • I have updated the documentation (if required).
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I added a picture of a cute animal cause it's fun

@lirantal lirantal merged commit 17fe528 into master May 24, 2023
12 checks passed
@lirantal lirantal self-assigned this May 24, 2023
@lirantal lirantal added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels May 24, 2023
@lirantal lirantal deleted the fix/shadowed-error-variable branch July 7, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant