Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allowed package name aliases #176

Merged
merged 2 commits into from
Aug 1, 2023
Merged

Conversation

lirantal
Copy link
Owner

@lirantal lirantal commented Aug 1, 2023

Description

Fix #175

Types of changes

Package name aliases such as depicted in #175 would cause the --validate-package-names flag to trigger an issue. This PR creates a new trusted policy allow-list to match package names with their alias as pairs.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@lirantal lirantal added the documentation Improvements or additions to documentation label Aug 1, 2023
@lirantal lirantal self-assigned this Aug 1, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2023

Codecov Report

Patch coverage: 69.56% and project coverage change: +0.08% 🎉

Comparison is base (e76cce1) 97.87% compared to head (ffc5ac7) 97.96%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #176      +/-   ##
==========================================
+ Coverage   97.87%   97.96%   +0.08%     
==========================================
  Files          13       13              
  Lines         377      393      +16     
  Branches       85       88       +3     
==========================================
+ Hits          369      385      +16     
  Misses          8        8              
Files Changed Coverage Δ
packages/lockfile-lint/src/config.js 100.00% <ø> (ø)
...le-lint-api/src/validators/ValidatePackageNames.js 84.09% <65.00%> (-15.91%) ⬇️
packages/lockfile-lint/src/validators/index.js 100.00% <100.00%> (+13.46%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lirantal lirantal merged commit edd2a9a into main Aug 1, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mark results as OK, how?
2 participants