Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support host:port syntax #94

Merged
merged 1 commit into from
May 13, 2020
Merged

fix: support host:port syntax #94

merged 1 commit into from
May 13, 2020

Conversation

lirantal
Copy link
Owner

Description

This PR fixes the problem where a host is provided with a port, such as mydomain.com:1234 and treats it as-is if it can't parse it.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Related Issue

Fixes #93

@lirantal lirantal added the bug Something isn't working label May 13, 2020
@lirantal lirantal self-assigned this May 13, 2020
@lirantal lirantal merged commit 37d8eef into master May 13, 2020
@lirantal lirantal mentioned this pull request May 13, 2020
Closed
@lirantal lirantal deleted the fix/host-and-port-support branch July 7, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lirantal lirantal

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

allowed-hosts failing on urls with port and no scheme
1 participant
@lirantal