Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace axios with node-fetch (or other?) #169

Closed
lirantal opened this issue Nov 24, 2020 · 2 comments
Closed

Replace axios with node-fetch (or other?) #169

lirantal opened this issue Nov 24, 2020 · 2 comments
Assignees
@wafuwafu13
Labels
enhancement good first issue help wanted

Comments

@lirantal
Copy link
Owner

Expected Behavior

Replace the axios dependency with another lightweight HTTP. Perhaps even use the built-in one with a wrapper, or something as lightweight as node-fetch.

Current Behavior

Currently all calls are being done with the the axios npm package which I'd like to replace for a lower dependency footprint.
wafuwafu13 pushed a commit to wafuwafu13/npq that referenced this issue Nov 24, 2020
perf(package.json): perf/install-node-fetch
54fc09f 
perf/install-node-fetch

BREAKING CHANGE: install-node-fetch

perf lirantal#169
wafuwafu13 pushed a commit to wafuwafu13/npq that referenced this issue Nov 24, 2020
perf(repo.marshall.js): replace-axios-with-node-fetch
73dea6e 
replace-axios-with-node-fetch

perf lirantal#169
@wafuwafu13 wafuwafu13 mentioned this issue Nov 24, 2020
Merged
7 tasks
@wafuwafu13
Copy link
Contributor

Hi :)
I'm trying this issue now!

@lirantal
Copy link
Owner Author

Thanks! Let's chat on the PR

wafuwafu13 pushed a commit to wafuwafu13/npq that referenced this issue Nov 26, 2020
perf(snyk.marshall.js): replace axios with node-fetch
10b50b8 
perf lirantal#169
wafuwafu13 pushed a commit to wafuwafu13/npq that referenced this issue Nov 26, 2020
perf(packagerepo-utils.js): replace axios with node-fetch
daa1a6a 
perf lirantal#169
@lirantal lirantal closed this as completed Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wafuwafu13 wafuwafu13

Labels
enhancement good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lirantal @wafuwafu13