Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New logo for NPQ #33

Merged
merged 8 commits into from
May 2, 2018
Merged

New logo for NPQ #33

merged 8 commits into from
May 2, 2018

Conversation

jackingpanda
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Apr 29, 2018

Codecov Report

Merging #33 into master will decrease coverage by 0.82%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
- Coverage   94.87%   94.04%   -0.83%     
==========================================
  Files           4        5       +1     
  Lines          78       84       +6     
  Branches        9       11       +2     
==========================================
+ Hits           74       79       +5     
- Misses          4        5       +1
Impacted Files Coverage Δ
lib/marshalls/baseMarshall.js 84% <0%> (-1%) ⬇️
lib/helpers/warning.js 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85ef274...17a91b9. Read the comment docs.

Copy link
Owner

@lirantal lirantal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks.
Can you put it in a .github/ directory?

@jackingpanda
Copy link
Contributor Author

Okay. I've put it in .github directory.

@lirantal
Copy link
Owner

lirantal commented May 2, 2018

Thank you!

@lirantal lirantal merged commit b657169 into lirantal:master May 2, 2018
@lirantal lirantal mentioned this pull request May 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants