Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/6 filename with date #12

Merged
merged 2 commits into from Nov 29, 2019
Merged

Conversation

arszh
Copy link
Contributor

@arszh arszh commented Nov 29, 2019

Description

Added ability to insert date in filename to make file unique and not override previous file , also to know date when file was exported. To use should add param and value : 'isDated: true' in code or add argument '--dated' in CLI.
Added test.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [+] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Related Issue

#6

Motivation and Context

File names are unique and don't override each other and export date is known

How Has This Been Tested?

The been tested with real questionary in typeform and new test

Screenshots (if appropriate):

Checklist:

  • [+] I have updated the documentation (if required).
  • [+] I have read the CONTRIBUTING document.
  • [+] I have added tests to cover my changes.
  • [+] All new and existing tests passed.
  • I added a picture of a cute animal cause it's fun

add ability to insert date in filename to make file unique and not override previous file , also to know date when file was created
add momentjs
add utils.js with utils for string and date
add test
add argument --dated to cli

close lirantal#6
@lirantal lirantal self-requested a review November 29, 2019 14:11
@lirantal lirantal added the enhancement New feature or request label Nov 29, 2019
@lirantal
Copy link
Owner

Looks great ✨

@lirantal lirantal merged commit 0a56e8f into lirantal:master Nov 29, 2019
@lirantal
Copy link
Owner

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants