Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the shell work again #6

Closed
4 of 6 tasks
plfiorini opened this issue Aug 3, 2016 · 4 comments
Closed
4 of 6 tasks

Make the shell work again #6

plfiorini opened this issue Aug 3, 2016 · 4 comments
Assignees
@plfiorini
Milestone
M2

Comments

@plfiorini
Copy link
Member

plfiorini commented Aug 3, 2016 •
edited
Loading

Latest changes broke the shell:

  • Windows are not displayed anymore
  • Panel doesn't show icons
  • Drawer doesn't resize to contents
  • Shortcuts don't work anymore
  • Panel can't be moved anymore
  • Panel size cannot be changed anymore
@plfiorini plfiorini added this to the M2 milestone Aug 3, 2016
@plfiorini plfiorini self-assigned this Aug 3, 2016
@plfiorini plfiorini mentioned this issue Aug 3, 2016
Merged
@iBelieve
Copy link
Member

iBelieve commented Aug 7, 2016

@plfiorini Both the issues should be fixed now. Have you found any other features broken by my refactoring?

@plfiorini
Copy link
Member Author

Not sure if it's related to the refactoring but the drawer width is supposed to adapt to the contents width and it doesn't do it anymore.

@plfiorini
Copy link
Member Author

@ibeliever Updated the todo list

plfiorini added a commit that referenced this issue Aug 14, 2016
@plfiorini
Fix keybindings
674c70c 
Keybindings broke with the refactoring.

Issue: #6
@plfiorini
Copy link
Member Author

Move panel improvements to M3 because it's not a priority.
I want to get something in shape for M2 even if it's earlier than expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plfiorini plfiorini

Labels
None yet
Projects
None yet
Milestone
M2
Development

No branches or pull requests
2 participants
@plfiorini @iBelieve