-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Service agent/fix forever ack bug #104
Open
hoa-grvt
wants to merge
27
commits into
lirm:master
Choose a base branch
from
gravity-technologies:service-agent/fix-forever-ack-bug
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Service agent/fix forever ack bug #104
hoa-grvt
wants to merge
27
commits into
lirm:master
from
gravity-technologies:service-agent/fix-forever-ack-bug
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure Close Client Conductor
Offer to cluster
issue-14: move retry logic out of consensus_module_proxy
issue-19: onServiceAction must always send an ack
… egress publication.
issue-20: Fix broken cluster_service_agent.takeSnapshot
issue-18 : disconnect egress pub on clustered_service_agent.onSessionClose
* issue-12 : Disconnect egress publication when going into election * Change close to disconnect
* Fix incomplete work in slow duty cycle * Address code review comment
* issue-21: fix issues with recoverState * Add archive poll for error resp and image close check err in loadstate * Remove panic and add err check for wrong snapshotTypeId exit on loader --------- Co-authored-by: Duc Hoa, Nguyen <hoa@grvt.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.