Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Intervals multiplication #81

Closed
Baccega opened this issue Apr 21, 2021 · 0 comments · Fixed by #80
Closed

[BUG] Intervals multiplication #81

Baccega opened this issue Apr 21, 2021 · 0 comments · Fixed by #80
Assignees
@Baccega
Labels
🎊 resolution:resolved Bug or feature resolved - might not have been merged to master yet 🔍 scope:analysis Work regarding abstract domains or fixpoint algorithms 🐛 type:bug Something isn't working
Projects
LiSA
Milestone
0.1b1

Comments

@Baccega
Copy link
Contributor

Baccega commented Apr 21, 2021

Description
There is a mistake in the current implementation of interval multiplication: it calculates x2 * y2 in the intervals multiplication equations, instead of x1 * y2.
Source: https://en.wikipedia.org/wiki/Interval_arithmetic#Interval_operators

Reproducibility information
This bug was introduced in commit ae11414 , on master branch inside the file lisa/src/test/java/it/unive/lisa/test/imp/tutorial/intervals/Intv.java .
You can reproduce this bug by doing operations in your programs like: [5,5] * [10,10], that returns: [50, 100] instead of the correct answer: [50, 50].
@Baccega Baccega added the 🐛 type:bug Something isn't working label Apr 21, 2021
@lucaneg lucaneg added this to TODO in LiSA via automation Apr 21, 2021
@lucaneg lucaneg added this to the 0.1a5 milestone Apr 21, 2021
@lucaneg lucaneg assigned Baccega and unassigned lucaneg Apr 21, 2021
Baccega added a commit to Baccega/lisa that referenced this issue Apr 21, 2021
@Baccega
lisa-analyzer#81 Fixing Intervals multiplications
d4568f5
@Baccega Baccega mentioned this issue Apr 21, 2021
Merged
LiSA automation moved this from TODO to DONE Apr 21, 2021
@lucaneg lucaneg added the 🎊 resolution:resolved Bug or feature resolved - might not have been merged to master yet label Apr 21, 2021
@lucaneg lucaneg moved this from DONE to MERGED in LiSA Apr 30, 2021
@lucaneg lucaneg added the 🔍 scope:analysis Work regarding abstract domains or fixpoint algorithms label Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Baccega Baccega

Labels
🎊 resolution:resolved Bug or feature resolved - might not have been merged to master yet 🔍 scope:analysis Work regarding abstract domains or fixpoint algorithms 🐛 type:bug Something isn't working
Projects
No open projects
LiSA
  
MERGED
Milestone
0.1b1
Development

Successfully merging a pull request may close this issue.

Interval multiplication fix Baccega/lisa
2 participants
@Baccega @lucaneg