Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQUEST] CFG element location should be not null #84

Closed
VincenzoArceri opened this issue Apr 23, 2021 · 0 comments · Fixed by #66
Closed

[FEATURE REQUEST] CFG element location should be not null #84

VincenzoArceri opened this issue Apr 23, 2021 · 0 comments · Fixed by #66
Assignees
@VincenzoArceri
Labels
🎊 resolution:resolved Bug or feature resolved - might not have been merged to master yet 🏛 scope:program-structure Work regarding the program structure 🎆 type:feature New feature or request
Projects
LiSA
Milestone
0.1b1

Comments

@VincenzoArceri
Copy link
Collaborator

Description
We should ensure that the code location of each cfg element (Parameter, CFGDescriptor, CompilationUnit, etc) is not null. If the code location of an element is unknown, we should put the unknown location of the corresponding CodeLocation concrete implementation (e.g., for SourceCodeLocation we should put new SourceCodeLocation(null, -1, -1)).
@VincenzoArceri VincenzoArceri added the 🎆 type:feature New feature or request label Apr 23, 2021
@VincenzoArceri VincenzoArceri added this to the 0.1a5 milestone Apr 23, 2021
@VincenzoArceri VincenzoArceri self-assigned this Apr 23, 2021
@VincenzoArceri VincenzoArceri added this to TODO in LiSA via automation Apr 23, 2021
VincenzoArceri added a commit that referenced this issue Apr 23, 2021
@VincenzoArceri
#84 code location nullness check
ee4307a
@lucaneg lucaneg moved this from TODO to DOING in LiSA Apr 23, 2021
@VincenzoArceri VincenzoArceri mentioned this issue Apr 26, 2021
Merged
@lucaneg lucaneg added the 🎊 resolution:resolved Bug or feature resolved - might not have been merged to master yet label Apr 30, 2021
@lucaneg lucaneg moved this from DOING to DONE in LiSA Apr 30, 2021
lucaneg added a commit that referenced this issue Apr 30, 2021
@lucaneg
#84 enforced nullness check also inside SourceCodeLocation
4b538bd
LiSA automation moved this from DONE to MERGED Apr 30, 2021
@lucaneg lucaneg added the 🏛 scope:program-structure Work regarding the program structure label Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VincenzoArceri VincenzoArceri

Labels
🎊 resolution:resolved Bug or feature resolved - might not have been merged to master yet 🏛 scope:program-structure Work regarding the program structure 🎆 type:feature New feature or request
Projects
No open projects
LiSA
  
MERGED
Milestone
0.1b1
Development

Successfully merging a pull request may close this issue.

Annotations support lisa-analyzer/lisa
2 participants
@VincenzoArceri @lucaneg