Axes ordering handling and unit tests for GaussianVisLayer in models.dbm.layer #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Retrieving recent pylearn2 additions before finalizing dbm unit tests
this merge is necessary,
| if nvis is None: | ||
| assert rows is not None | ||
| assert cols is not None | ||
| assert channels is not None | ||
| self.space = Conv2DSpace(shape=[rows,cols], num_channels=channels, axes=axes) | ||
| # To make GaussianVisLayer compatible with any axis ordering |
There was a problem hiding this comment.
I won't make you fix this to get the PR merged, but according to PEP8 style there should be a space on both sides of the = sign. (I know most of the library is not PEP8 compliant, but we're trying to move toward it being so)
|
Looks good overall. There are two small formatting problems, but I won't enforce these at the moment, just read my comments so you'll know for next time. Pretty soon we'll have tests that automatically enforce the format requirements. |
goodfeli
pushed a commit
that referenced
this pull request
Mar 10, 2014
Axes ordering handling and unit tests for GaussianVisLayer in models.dbm.layer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Addressed NotImplementedErrors in dbm.layer.GaussianVisLayer regarding axes ordering for Conv2DSpace shape
-Added basic unit tests for GaussianVisLayer