Print replaced by logging in optimization and packaged_dependencies folders #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -148,7 +152,7 @@ def __init__(self, objective, params, inputs = None, | |||
| self.param_to_grad_shared = param_to_grad_shared | |||
|
|
|||
| if self.verbose: | |||
There was a problem hiding this comment.
On line 127 let's change logger level to debug if self.verbose == True
There was a problem hiding this comment.
And remove all "if verbose" statements?
There was a problem hiding this comment.
Let's leave the if statement to be there for now to not break anything.
Write a TODO note somewhere maybe in the file docstring to remove the verbose later.
There was a problem hiding this comment.
Ok. There is multiple levels of verbosity too (3: 0, 1 and >1) but I'll just set the level to DEBUG if verbose is True (== 1), or maybe >0?
There was a problem hiding this comment.
If > 0 seems what we want to do.
memimo
added a commit
that referenced
this pull request
Mar 28, 2014
Print replaced by logging in optimization and packaged_dependencies folders
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of the pull request #718 for issue #41.
I didn't replace prints in the file packaged_dependencies/theano_linear/unshared_conv/unshared_conv.py as there kind of comments.