Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clicked coordinate calculation error of eye icon #11

Closed
nickwongwong opened this issue May 21, 2016 · 2 comments
Closed

clicked coordinate calculation error of eye icon #11

nickwongwong opened this issue May 21, 2016 · 2 comments
Assignees
Labels
Milestone

Comments

@nickwongwong
Copy link

When we use "padding" or "center_horizontal" of PasswordView, (getRight() - getCompoundDrawables()[2].getBounds().width()) will not show the true location of eye icon.
In this way, onTouchEvent can not handle the click event correctly.
Using getWidth() instead of getRight(), and getPaddingRight()

@nickwongwong nickwongwong changed the title coordinate calculation error of eye icon clicked coordinate calculation error of eye icon May 21, 2016
@behelit
Copy link

behelit commented Jun 21, 2016

Having the same issue. If I use padding, the user can only toggle it by tapping the very end of the edit text field (i.e the last pixel)
Same results when using padding on either the TextInputLayout or directly on the PasswordView

@lisawray lisawray added this to the 1.0 milestone Jul 22, 2016
@lisawray lisawray self-assigned this Jul 22, 2016
@lisawray lisawray added the bug label Jul 22, 2016
@lisawray
Copy link
Owner

Fixed! #18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants