Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Allow configuration using environment variables #87

Closed
hendrikhofstadt opened this issue May 3, 2018 · 0 comments
Closed

Allow configuration using environment variables #87

hendrikhofstadt opened this issue May 3, 2018 · 0 comments

Comments

@hendrikhofstadt
Copy link

hendrikhofstadt commented May 3, 2018

The Docker image should allow users to specify all of the config variables using environment variables.

Like e.g. LISK_FORGING_SECRET_<X> please consult #85 as a reference implementation.

Baking in a config.json file is not a best-practice and should not be done in order to avoid leaking secrets.

This will also make #78 much easier since ports, seed nodes etc. could be changed from e.g. a docker-compose file.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants