Converters #47
Open
Converters #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`update` does almost the same as `from-json` but in a slightly different way. `update` based on `define-converters` handles it for free with no need for separate methods for each class.
…eded for getting the data from tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a system that, while requiring some maintaining itself, makes maintaining the objects somewhat easier and less error-prone. I've found and fixed several bugs when converting objects to use it. Also, updated most objects to mostly-recent API.
With that, I'll stop using Discord in favour of Matrix. If you want to merge this PR with some changes I'll still help with that.