Issue1188

[lisphilar]

Related issues

#1188

What was changed

• close [Fix] UnExpectedValueRangeError when phase appending after prediction #1188

[sourcery-ai]

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.13%.

Quality metrics	Before	After	Change
Complexity	2.59 ⭐	2.55 ⭐	-0.04 👍
Method Length	120.48 😞	121.17 😞	0.69 👎
Working memory	9.68 🙂	9.66 🙂	-0.02 👍
Quality	61.28% 🙂	61.41% 🙂	0.13% 👍

Other metrics	Before	After	Change
Lines	584	585	1

Changed files	Quality Before	Quality After	Quality Change
covsirphy/science/ode_scenario.py	56.84% 🙂	57.02% 🙂	0.18% 👍
tests/test_science/test_ode_scenario.py	81.56% ⭐	80.88% ⭐	-0.68% 👎

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
covsirphy/science/ode_scenario.py	ODEScenario.compare_cases	5 ⭐	356 ⛔	14 😞	40.19% 😞	Try splitting into smaller methods. Extract out complex expressions
covsirphy/science/ode_scenario.py	ODEScenario._append	6 ⭐	303 ⛔	12 😞	43.55% 😞	Try splitting into smaller methods. Extract out complex expressions
covsirphy/science/ode_scenario.py	ODEScenario.compare_param	4 ⭐	232 ⛔	14 😞	45.67% 😞	Try splitting into smaller methods. Extract out complex expressions
covsirphy/science/ode_scenario.py	ODEScenario.represent	4 ⭐	217 ⛔	13 😞	48.02% 😞	Try splitting into smaller methods. Extract out complex expressions
covsirphy/science/ode_scenario.py	ODEScenario.predict	1 ⭐	242 ⛔	13 😞	49.50% 😞	Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

[codecov]

Codecov Report

Merging #1189 (34566f6) into master (a5ffbbf) will increase coverage by 0.05%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #1189      +/-   ##
==========================================
+ Coverage   88.85%   88.90%   +0.05%     
==========================================
  Files          46       46              
  Lines        3364     3363       -1     
==========================================
+ Hits         2989     2990       +1     
+ Misses        375      373       -2     

Impacted Files	Coverage Δ
covsirphy/science/ode_scenario.py	67.22% <66.66%> (+0.69%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.