Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: #1160, specify encoding #1193

Merged
merged 1 commit into from
Sep 13, 2022
Merged

Conversation

lisphilar
Copy link
Owner

Related issues

#1160

What was changed

  • Specify "utf-8" as the encoding when downloading CSV files.

@lisphilar lisphilar added this to the Release v2.26.3 milestone Sep 13, 2022
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Sep 13, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.16%.

Quality metrics Before After Change
Complexity 4.11 ⭐ 4.11 ⭐ 0.00
Method Length 70.50 🙂 71.33 🙂 0.83 👎
Working memory 8.27 🙂 8.27 🙂 0.00
Quality 69.62% 🙂 69.46% 🙂 -0.16% 👎
Other metrics Before After Change
Lines 103 103 0
Changed files Quality Before Quality After Quality Change
covsirphy/downloading/provider.py 69.62% 🙂 69.46% 🙂 -0.16% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
covsirphy/downloading/provider.py _DataProvider.read_csv 9 🙂 182 😞 11 😞 49.17% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@lisphilar lisphilar merged commit 642b108 into master Sep 13, 2022
@delete-merged-branch delete-merged-branch bot deleted the issue1160_specify_encoding branch September 13, 2022 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant